Review Results

Comment

The change only updates .SRCINFO metadata to reflect a new upstream git snapshot (pkgver bump from 1.1.r47.g1fd0491 to 1.2.r0.g0e20d2c) and resets pkgrel from 2 to 1. No build logic, sources, install scripts, or permissions are changed in the provided diff. Based on the reviewed hunk alone, there are no security red flags.

@@ -1,7 +1,7 @@
 pkgbase = uavs3d-git
 	pkgdesc = An AVS3 decoder supporting AVS3-P2 baseline profile (git version)
-	pkgver = 1.1.r47.g1fd0491
-	pkgrel = 2
+	pkgver = 1.2.r0.g0e20d2c
+	pkgrel = 1
 	url = https://github.com/uavs3/uavs3d/
 	arch = x86_64
 	license = BSD-3-Clause

Comment

The change only updates the recorded SHA-256 for the patch source `010-uavs3d-10bit.patch` in `.SRCINFO`. The source URL remains the official GitHub upstream repository over HTTPS, and there are no new build steps, scripts, or privilege-related changes in this diff. On its face this is a normal integrity metadata update, likely reflecting a patch content change. I did not see evidence here of malicious sourcing, network fetches, or packaging behavior changes.

@@ -13,6 +13,6 @@ pkgbase = uavs3d-git
 	source = git+https://github.com/uavs3/uavs3d.git
 	source = 010-uavs3d-10bit.patch
 	sha256sums = SKIP
-	sha256sums = 4440d93d1cf3d3cec1130e030a06d6e61ff874ee93fd01a5cb272da73b9c3fa6
+	sha256sums = 56dd2ce8503ae838db3de9e444c00f533a74705ab07ff2084367ed9f2cc3630b
 
 pkgname = uavs3d-git

Comment

The change only updates the line number in a patch hunk header from @@ -109 to @@ -118, with no modification to the patched content itself. This is a non-functional context adjustment and does not introduce any build, packaging, or runtime security risk.

@@ -1,6 +1,6 @@
 --- a/source/CMakeLists.txt
 +++ b/source/CMakeLists.txt
-@@ -109,7 +109,7 @@ MESSAGE(STATUS "Target CPU\t\t\t: ${UAVS3D_TARGET_CPU}")
+@@ -118,7 +118,7 @@ MESSAGE(STATUS "Target CPU\t\t\t: ${UAVS3D_TARGET_CPU}")
  find_package(Threads REQUIRED)
  set(prefix "${CMAKE_INSTALL_PREFIX}")
  set(includedir "include")

Comment

The change is low risk. It only updates the git snapshot version, resets pkgrel, refreshes the patch checksum, and changes the prepare() copy command from an explicit remove+copy to a forceful recursive copy. The source remains the official GitHub repo over HTTPS, and the patch content itself is benign: it only relocates the 10-bit library install path under /usr/lib/uavs3d-10bit to avoid file collisions. No new network fetches, privilege escalation, persistence, or suspicious install-time actions were introduced. The only notable issue is the use of `cp -af` in prepare(), but here it operates on local source trees within the build directory and does not write outside the package build context.

@@ -1,25 +1,26 @@
 # Maintainer: Daniel Bermond <dbermond@archlinux.org>
 
 pkgname=uavs3d-git
-pkgver=1.1.r47.g1fd0491
-pkgrel=2
+pkgver=1.2.r0.g0e20d2c
+pkgrel=1
 pkgdesc='An AVS3 decoder supporting AVS3-P2 baseline profile (git version)'
 arch=('x86_64')
 url='https://github.com/uavs3/uavs3d/'
 license=('BSD-3-Clause')
-depends=('glibc')
-makedepends=('cmake' 'git')
+depends=(
+    'glibc')
+makedepends=(
+    'cmake'
+    'git')
 provides=('uavs3d')
 conflicts=('uavs3d')
 source=('git+https://github.com/uavs3/uavs3d.git'
         '010-uavs3d-10bit.patch')
 sha256sums=('SKIP'
-            '4440d93d1cf3d3cec1130e030a06d6e61ff874ee93fd01a5cb272da73b9c3fa6')
+            '56dd2ce8503ae838db3de9e444c00f533a74705ab07ff2084367ed9f2cc3630b')
 
 prepare() {
-    [ -d uavs3d-10bit ] && rm -r uavs3d-10bit
-    cp -a uavs3d uavs3d-10bit
-    
+    cp -af uavs3d{,-10bit}
     patch -d uavs3d-10bit -Np1 -i "${srcdir}/010-uavs3d-10bit.patch"
 }
 

Comment

The change is a one-line PKGBUILD edit that replaces the CMake flag `-Wno-dev` with `-Wno-author`. This does not introduce any new source, network access, privilege escalation, install-script behavior, or packaging changes. It appears to be a harmless adjustment to suppress a different class of CMake warnings, with no security impact visible in the provided diff.

@@ -35,7 +36,7 @@ build() {
         '-DCMAKE_POLICY_VERSION_MINIMUM:STRING=3.5.0'
         '-DCMAKE_SKIP_RPATH:BOOL=YES'
         '-DBUILD_SHARED_LIBS:BOOL=ON'
-        '-Wno-dev')
+        '-Wno-author')
     
     cmake -B build -S uavs3d "${_cmake_opts[@]}"
     cmake --build build