Review Results

Comment

The change is a straightforward upstream version bump in .SRCINFO: it updates the package version/release, switches the project homepage and source tarball from HermanChen/mpp to the official rockchip-linux/mpp repository, and refreshes the checksums. There are no new build steps, no added scripts, no network-at-build behavior, and no privilege/persistence mechanisms introduced by this metadata-only diff. I did not see any integrity red flags in the provided hunk.

@@ -1,18 +1,18 @@
 pkgbase = rockchip-mpp
 	pkgdesc = Rockchip Media Process Platform (MPP)
-	pkgver = 1.0.11
-	pkgrel = 3
+	pkgver = 1.1.0
+	pkgrel = 1
 	epoch = 1
-	url = https://github.com/HermanChen/mpp/
+	url = https://github.com/rockchip-linux/mpp/
 	arch = x86_64
 	license = Apache-2.0
 	license = MIT
 	makedepends = cmake
 	depends = glibc
 	depends = libstdc++
-	source = https://github.com/HermanChen/mpp/archive/1.0.11/rockchip-mpp-HermanChen-1.0.11.tar.gz
+	source = https://github.com/rockchip-linux/mpp/archive/1.1.0/rockchip-mpp-1.1.0.tar.gz
 	source = 010-rockchip-mpp-silence-unwanted-log-messages.patch
-	sha256sums = e97f67e0d2e028ef444099443b6e77efea9f7db83edcbf080f539a44c1c2d36c
-	sha256sums = 9764a01c08f5c1883e675295f8ebc8c26604a7b48d1f9c7df4c9d8c95f32dc26
+	sha256sums = 7bb0040f364468ad9abbb71a04553ebc6a5814584e083c2fc9a553783e9656df
+	sha256sums = bdec0c21ffdeadf128d670a304be59eccb253e45ff78a1ee70a0f4b305ff05e0
 
 pkgname = rockchip-mpp

Comment

The change is a trivial patch-context line number adjustment in an existing patch file. It does not alter any code, build logic, install scripts, or shipped artifacts beyond keeping the patch applicable after upstream line shifts. No security-relevant behavior is introduced.

@@ -13,7 +13,7 @@
      if (mpp_get_mpp_service_name()) {
 --- a/osal/mpp_soc.c
 +++ b/osal/mpp_soc.c
-@@ -1032,7 +1032,7 @@ static void read_soc_name(char *name, rk
+@@ -1114,7 +1114,7 @@ static void read_soc_name(char *name, rk
      rk_s32 fd = open(path, O_RDONLY);
  
      if (fd < 0) {

Comment

The change is low risk. It updates the package to a new upstream release, switches the source URL from the old fork to the official rockchip-linux repository, and refreshes checksums accordingly. The only added build-time behavior is a local patch application in prepare(), but the patch itself is already part of the package sources and there are no signs here of network fetches, privilege escalation, install-script changes, or suspicious post-install persistence. The build flag change from -Wno-dev to -Wno-author is unusual but benign in context; it only affects CMake warnings. No high-confidence security issue is evident in this diff.

@@ -1,40 +1,35 @@
 # Maintainer: Daniel Bermond <dbermond@archlinux.org>
 
 pkgname=rockchip-mpp
-pkgver=1.0.11
-pkgrel=3
+pkgver=1.1.0
+pkgrel=1
 epoch=1
 pkgdesc='Rockchip Media Process Platform (MPP)'
 arch=('x86_64')
-# https://github.com/HermanChen/mpp/issues/71
-# https://github.com/HermanChen/mpp/issues/73
-#url='https://github.com/rockchip-linux/mpp/'
-url='https://github.com/HermanChen/mpp/'
+url='https://github.com/rockchip-linux/mpp/'
 license=('Apache-2.0' 'MIT')
 depends=(
     'glibc'
     'libstdc++')
 makedepends=(
     'cmake')
-source=("https://github.com/HermanChen/mpp/archive/${pkgver}/${pkgname}-HermanChen-${pkgver}.tar.gz"
+source=("https://github.com/rockchip-linux/mpp/archive/${pkgver}/${pkgname}-${pkgver}.tar.gz"
         '010-rockchip-mpp-silence-unwanted-log-messages.patch')
-sha256sums=('e97f67e0d2e028ef444099443b6e77efea9f7db83edcbf080f539a44c1c2d36c'
-            '9764a01c08f5c1883e675295f8ebc8c26604a7b48d1f9c7df4c9d8c95f32dc26')
+sha256sums=('7bb0040f364468ad9abbb71a04553ebc6a5814584e083c2fc9a553783e9656df'
+            'bdec0c21ffdeadf128d670a304be59eccb253e45ff78a1ee70a0f4b305ff05e0')
 
 prepare() {
+    # silence unwanted log messages described in https://github.com/rockchip-linux/mpp/issues/820
     patch -d "mpp-${pkgver}" -Np1 -i "${srcdir}/010-rockchip-mpp-silence-unwanted-log-messages.patch"
 }
 
 build() {
-    # fix build with gcc 15+
-    export CFLAGS+=' -Wno-error=incompatible-pointer-types'
-    
     cmake -B build -S "mpp-${pkgver}" \
         -G 'Unix Makefiles' \
         -DCMAKE_BUILD_TYPE:STRING='None' \
         -DCMAKE_INSTALL_PREFIX:PATH='/usr' \
         -DENABLE_VPROC_VDPP:BOOL='ON' \
-        -Wno-dev
+        -Wno-author
     cmake --build build
 }