AUR AI Reviewer

Review Results

Version #2656 of argagg · commit 7951330c009f · status Reviewed

Risk 0/5 · Safe PKGBUILD
Result #4350

Comment

The change is a straightforward CMake invocation cleanup: it switches to out-of-source build syntax (`cmake -B build -S .`), uses `cmake --build` for build/install/test, and removes a local `-DCMAKE_CXX_FLAGS='-O0'` override. I do not see any new network access, privilege escalation, suspicious downloads, or packaging-path changes. The package still builds from the declared source and installs via DESTDIR into `$pkgdir` as expected. No security-relevant red flags are introduced by this diff.

@@ -14,23 +14,21 @@ sha512sums=('85634bff33236ffcb0aea03a6fa4b3529b6d1faa03f8e030f3c5401fc453bb5e196
 
 
 build() {
-  mkdir -p "$pkgname-$pkgver/build"
-  cd "$pkgname-$pkgver/build"
+  cd "$pkgname-$pkgver"
 
-  cmake .. \
+  cmake -B build -S . \
     -DCMAKE_INSTALL_PREFIX=/usr \
-    -DCMAKE_POLICY_VERSION_MINIMUM='3.5' \
-    -DCMAKE_CXX_FLAGS='-O0'
+    -DCMAKE_POLICY_VERSION_MINIMUM='3.5'
 
-  make
+  cmake --build build
 }
 
 package() {
-  cd "$pkgname-$pkgver/build"
-  make DESTDIR="${pkgdir}" install
+  cd "$pkgname-$pkgver"
+  DESTDIR="${pkgdir}" cmake --build build -- install
 }
 
 check () {
-  cd "$pkgname-$pkgver/build"
-  make test
+  cd "$pkgname-$pkgver"
+  cmake --build build -- test
 }