Comment
The patch only adjusts updatecheck.sh to use pacman -Q for installed package versions and writes all metadata into VERSION_FILE_TMP instead of VERSION_FILE, plus a service control call in piholeLogFlush.sh is switched from `service` to `systemctl`. I do not see any added network fetches, privilege escalation, persistence, or other malicious behavior in the provided hunk. The change appears to be packaging/compatibility cleanup for Arch Linux rather than a security-sensitive modification.
@@ -22,81 +22,65 @@ diff -uprN pi-hole-6.3/advanced/Scripts/piholeLogFlush.sh pi-hole-6.3.cust/advan
fi
FTLFILE=$(getFTLConfigValue "files.log.ftl")
if [ -z "$FTLFILE" ]; then
-@@ -105,13 +105,13 @@ else
- fi
-
- # Stop FTL to make sure it doesn't write to the database while we're deleting data
-- service pihole-FTL stop
-+ systemctl stop pihole-FTL
-
- # Delete most recent 24 hours from FTL's database, leave even older data intact (don't wipe out all history)
- deleted=$(pihole-FTL sqlite3 -ni "${DBFILE}" "DELETE FROM query_storage WHERE timestamp >= strftime('%s','now')-86400; select changes() from query_storage limit 1")
-
- # Restart FTL
-- service pihole-FTL restart
-+ systemctl restart pihole-FTL
- if [[ "$*" != *"quiet"* ]]; then
- echo -e "${OVER} ${TICK} Deleted ${deleted} queries from long-term query database"
- fi
--- pi-hole-6.3/advanced/Scripts/updatecheck.sh 2026-09-17 21:24:04.695634438 +0200
+++ pi-hole-6.3.cust/advanced/Scripts/updatecheck.sh 2026-09-17 21:24:23.221678486 +0200
-@@ -74,38 +74,26 @@ fi
-
+@@ -91,38 +91,26 @@
+
# get Core versions
-
+
-CORE_VERSION="$(get_local_version /etc/.pihole)"
+CORE_VERSION="$(pacman -Q pi-hole-core | awk '{print $2}' | cut -d- -f1)"
- addOrEditKeyValPair "${VERSION_FILE}" "CORE_VERSION" "${CORE_VERSION}"
-
+ addOrEditKeyValPair "${VERSION_FILE_TMP}" "CORE_VERSION" "${CORE_VERSION}"
+
-CORE_BRANCH="$(get_local_branch /etc/.pihole)"
+CORE_BRANCH="master"
- addOrEditKeyValPair "${VERSION_FILE}" "CORE_BRANCH" "${CORE_BRANCH}"
-
+ addOrEditKeyValPair "${VERSION_FILE_TMP}" "CORE_BRANCH" "${CORE_BRANCH}"
+
-CORE_HASH="$(get_local_hash /etc/.pihole)"
+CORE_HASH="builtfromreleasetarball"
- addOrEditKeyValPair "${VERSION_FILE}" "CORE_HASH" "${CORE_HASH}"
-
+ addOrEditKeyValPair "${VERSION_FILE_TMP}" "CORE_HASH" "${CORE_HASH}"
+
-GITHUB_CORE_VERSION="$(get_remote_version pi-hole "${CORE_BRANCH}")"
--addOrEditKeyValPair "${VERSION_FILE}" "GITHUB_CORE_VERSION" "${GITHUB_CORE_VERSION}"
+-addOrEditKeyValPair "${VERSION_FILE_TMP}" "GITHUB_CORE_VERSION" "${GITHUB_CORE_VERSION}"
-
-GITHUB_CORE_HASH="$(get_remote_hash pi-hole "${CORE_BRANCH}")"
--addOrEditKeyValPair "${VERSION_FILE}" "GITHUB_CORE_HASH" "${GITHUB_CORE_HASH}"
+-addOrEditKeyValPair "${VERSION_FILE_TMP}" "GITHUB_CORE_HASH" "${GITHUB_CORE_HASH}"
-
# get Web versions
-
+
-WEB_VERSION="$(get_local_version "${ADMIN_INTERFACE_DIR}")"
+WEB_VERSION="$(pacman -Q pi-hole-web | awk '{print $2}' | cut -d- -f1)"
- addOrEditKeyValPair "${VERSION_FILE}" "WEB_VERSION" "${WEB_VERSION}"
-
+ addOrEditKeyValPair "${VERSION_FILE_TMP}" "WEB_VERSION" "${WEB_VERSION}"
+
-WEB_BRANCH="$(get_local_branch "${ADMIN_INTERFACE_DIR}")"
+WEB_BRANCH="master"
- addOrEditKeyValPair "${VERSION_FILE}" "WEB_BRANCH" "${WEB_BRANCH}"
-
+ addOrEditKeyValPair "${VERSION_FILE_TMP}" "WEB_BRANCH" "${WEB_BRANCH}"
+
-WEB_HASH="$(get_local_hash "${ADMIN_INTERFACE_DIR}")"
+WEB_HASH="builtfromreleasetarball"
- addOrEditKeyValPair "${VERSION_FILE}" "WEB_HASH" "${WEB_HASH}"
-
+ addOrEditKeyValPair "${VERSION_FILE_TMP}" "WEB_HASH" "${WEB_HASH}"
+
-GITHUB_WEB_VERSION="$(get_remote_version web "${WEB_BRANCH}")"
--addOrEditKeyValPair "${VERSION_FILE}" "GITHUB_WEB_VERSION" "${GITHUB_WEB_VERSION}"
+-addOrEditKeyValPair "${VERSION_FILE_TMP}" "GITHUB_WEB_VERSION" "${GITHUB_WEB_VERSION}"
-
-GITHUB_WEB_HASH="$(get_remote_hash web "${WEB_BRANCH}")"
--addOrEditKeyValPair "${VERSION_FILE}" "GITHUB_WEB_HASH" "${GITHUB_WEB_HASH}"
+-addOrEditKeyValPair "${VERSION_FILE_TMP}" "GITHUB_WEB_HASH" "${GITHUB_WEB_HASH}"
-
# get FTL versions
-
+
FTL_VERSION="$(pihole-FTL version)"
-@@ -117,12 +105,6 @@ addOrEditKeyValPair "${VERSION_FILE}" "F
+@@ -134,12 +122,6 @@
FTL_HASH="$(pihole-FTL --hash)"
- addOrEditKeyValPair "${VERSION_FILE}" "FTL_HASH" "${FTL_HASH}"
-
+ addOrEditKeyValPair "${VERSION_FILE_TMP}" "FTL_HASH" "${FTL_HASH}"
+
-GITHUB_FTL_VERSION="$(get_remote_version FTL "${FTL_BRANCH}")"
--addOrEditKeyValPair "${VERSION_FILE}" "GITHUB_FTL_VERSION" "${GITHUB_FTL_VERSION}"
+-addOrEditKeyValPair "${VERSION_FILE_TMP}" "GITHUB_FTL_VERSION" "${GITHUB_FTL_VERSION}"
-
-GITHUB_FTL_HASH="$(get_remote_hash FTL "${FTL_BRANCH}")"
--addOrEditKeyValPair "${VERSION_FILE}" "GITHUB_FTL_HASH" "${GITHUB_FTL_HASH}"
+-addOrEditKeyValPair "${VERSION_FILE_TMP}" "GITHUB_FTL_HASH" "${GITHUB_FTL_HASH}"
-
# get Docker versions
-
+
if [[ "${DOCKER_TAG}" ]]; then
diff -uprN pi-hole-6.3/advanced/Templates/logrotate pi-hole-6.3.cust/advanced/Templates/logrotate
--- pi-hole-6.3/advanced/Templates/logrotate 2025-11-27 19:10:51.000000000 +0100