Review Results

Comment

The only change in this .SRCINFO hunk is a version bump from 2.1.5 to 2.1.6. No sources, checksums, build steps, install scripts, permissions, or package metadata affecting trust boundaries were changed in the reviewed diff. Based on this hunk alone, there is no security concern.

@@ -1,6 +1,6 @@
 pkgbase = droidcam
 	pkgdesc = A tool to turn your phone/tablet into a wireless/usb webcam
-	pkgver = 2.1.5
+	pkgver = 2.1.6
 	pkgrel = 1
 	epoch = 1
 	url = https://github.com/dev47apps/droidcam-linux-client

Comment

The change only bumps the upstream source tarball from droidcam 2.1.5 to 2.1.6 and updates the corresponding SHA-256 checksum in .SRCINFO. The source remains an HTTPS GitHub release archive from the same upstream project, with no new sources, scripts, build steps, or packaging metadata changes that would introduce execution, persistence, or integrity risks. No security-relevant red flags are visible in this diff alone.

@@ -15,10 +15,10 @@ pkgbase = droidcam
 	makedepends = speex
 	optdepends = android-tools: for Android USB connection
 	optdepends = usbmuxd: for iOS USB connection
-	source = droidcam-2.1.5.tar.gz::https://github.com/dev47apps/droidcam-linux-client/archive/v2.1.5.tar.gz
+	source = droidcam-2.1.6.tar.gz::https://github.com/dev47apps/droidcam-linux-client/archive/v2.1.6.tar.gz
 	source = dkms.conf
 	source = droidcam.conf
-	sha256sums = 00ec96ec7a660e4e3ffb2adc536d14af89c635766dadbf53326c1216187021f8
+	sha256sums = 2850f52d1d779e037f833fdf68518c31a88981d0897743ebdb9a2c8492e8033f
 	sha256sums = 20de9d14877732f2f75c21bdd4c335c71dcaeccab4ce348c6c0a210f622ceed2
 	sha256sums = 1d4b3ff98b4af9de77a24d1b6fad6e004deadf1f157eb800aa878ba1e7693dac
 

Comment

The change only bumps pkgver from 2.1.5 to 2.1.6 in PKGBUILD. No source URLs, build commands, install scripts, permissions, or packaging logic were modified in the provided diff hunk, so there is no new security-relevant behavior to assess from this change alone.

@@ -7,7 +7,7 @@
 pkgbase=droidcam
 pkgname=(droidcam v4l2loopback-dc-dkms)
 _name=droidcam-linux-client
-pkgver=2.1.5
+pkgver=2.1.6
 pkgrel=1
 epoch=1
 pkgdesc="A tool to turn your phone/tablet into a wireless/usb webcam"

Comment

The change is low risk. It only reorders/indents PKGBUILD logic, updates the source checksum, and moves the generated modprobe config path from the source tree root to the v4l2loopback subdirectory so it is installed from there. The added sed edits are straightforward path adjustments for the desktop file and source code, and there are no new network fetches, privilege escalations, persistence mechanisms, or suspicious install-time actions. I did not find any malicious behavior in the modified hunk.

@@ -20,55 +20,60 @@ optdepends=('android-tools: for Android USB connection'
 source=("${pkgbase}-${pkgver}.tar.gz::${url}/archive/v${pkgver}.tar.gz"
         "dkms.conf"
         "${pkgbase}.conf")
-sha256sums=('00ec96ec7a660e4e3ffb2adc536d14af89c635766dadbf53326c1216187021f8'
+sha256sums=('2850f52d1d779e037f833fdf68518c31a88981d0897743ebdb9a2c8492e8033f'
             '20de9d14877732f2f75c21bdd4c335c71dcaeccab4ce348c6c0a210f622ceed2'
             '1d4b3ff98b4af9de77a24d1b6fad6e004deadf1f157eb800aa878ba1e7693dac')
 
 prepare() {
-  # Generate the module loading configuration files
-  echo "options v4l2loopback_dc width=640 height=480" >| "${pkgbase}.modprobe.conf"
+    cd "${_name}-${pkgver}"
+    sed -i 's|/opt/droidcam-icon.png|/usr/share/pixmaps/droidcam.png|' src/droidcam.c
+    sed -e 's|/usr/local/bin/||' \
+        -e 's|/opt/droidcam-icon.png|droidcam|' \
+        -i droidcam.desktop
+    sed -i "s/@PKGVER@/${pkgver}/" "${srcdir}/dkms.conf"
 
-  sed "s/@PKGVER@/${pkgver}/" -i dkms.conf
-
-  cd "${_name}-${pkgver}"
-  sed 's|/opt/droidcam-icon.png|/usr/share/pixmaps/droidcam.png|' -i src/droidcam.c
-  sed -e 's|/usr/local/bin/||' -e 's|/opt/droidcam-icon.png|droidcam|' -i droidcam.desktop
+    # Generate the module loading configuration files
+    echo "options v4l2loopback_dc width=640 height=480" >|"v4l2loopback/${pkgbase}.modprobe.conf"
 }
 
 build() {
-  cd "${_name}-${pkgver}"
-
-  # All JPEG* parameters are needed to use shared version of libturbojpeg instead of
-  # static one.
-  #
-  # Also libusbmuxd requires an override while linking.
-  make JPEG_DIR='/usr/lib' JPEG_INCLUDE='/usr/include' USBMUXD='-lusbmuxd-2.0'
+    cd "${_name}-${pkgver}"
+    # All JPEG* parameters are needed to use shared version of libturbojpeg instead of static one.
+    # Also libusbmuxd requires an override while linking.
+    make JPEG_DIR='/usr/lib' JPEG_INCLUDE='/usr/include' USBMUXD='-lusbmuxd-2.0'
 }
 
 package_droidcam() {
-  depends=('alsa-lib' 'ffmpeg' 'glib2' 'glibc' 'gtk3' 'libappindicator-gtk3' 'libjpeg-turbo' 'libusbmuxd' 'libx11' 'pango' 'speex' 'V4L2LOOPBACK-MODULE')
+    depends=('alsa-lib'
+             'ffmpeg'
+             'glib2'
+             'glibc'
+             'gtk3'
+             'libappindicator-gtk3'
+             'libjpeg-turbo'
+             'libusbmuxd'
+             'libx11'
+             'pango'
+             'speex'
+             'V4L2LOOPBACK-MODULE')
 
-  cd "${_name}-${pkgver}"
-  # Install droidcam program files
-  install -Dm755 "${pkgname}" "${pkgname}-cli" -t "${pkgdir}/usr/bin"
-  install -Dm644 icon2.png "${pkgdir}/usr/share/pixmaps/${pkgname}.png"
-  install -Dm644 "${pkgname}.desktop" -t "${pkgdir}/usr/share/applications"
-  install -Dm644 "${srcdir}/${pkgname}.conf" -t "${pkgdir}/etc/modules-load.d"
+    cd "${_name}-${pkgver}"
+    install -Dm755 "${pkgname}" "${pkgname}-cli" -t "${pkgdir}/usr/bin"
+    install -Dm644 icon2.png "${pkgdir}/usr/share/pixmaps/${pkgname}.png"
+    install -Dm644 "${pkgname}.desktop" -t "${pkgdir}/usr/share/applications"
+    install -Dm644 "${srcdir}/${pkgname}.conf" -t "${pkgdir}/etc/modules-load.d"
 }
 
 package_v4l2loopback-dc-dkms() {
-  pkgdesc='v4l2-loopback kernel module - DroidCam version'
-  arch=('any')
-  depends=('dkms')
-  provides=('V4L2LOOPBACK-MODULE')
-  backup=("etc/modprobe.d/${pkgbase}.conf")
-
-  _pkgname='v4l2loopback-dc'
+    pkgdesc='v4l2-loopback kernel module - DroidCam version'
+    arch=('any')
+    depends=('dkms')
+    provides=('V4L2LOOPBACK-MODULE')
+    backup=("etc/modprobe.d/${pkgbase}.conf")
 
-  # Install module loading configuration
-  install -Dm644 "${pkgbase}.modprobe.conf" "${pkgdir}/etc/modprobe.d/${pkgbase}.conf"
+    _pkgname='v4l2loopback-dc'
 
-  # Install module source
-  cd "${_name}-${pkgver}/v4l2loopback"
-  install -Dm644 Makefile test.c v4l2loopback-dc.c "${srcdir}/dkms.conf" -t "${pkgdir}/usr/src/${_pkgname}-${pkgver}"
+    cd "${_name}-${pkgver}/v4l2loopback"
+    install -Dm644 "${pkgbase}.modprobe.conf" "${pkgdir}/etc/modprobe.d/${pkgbase}.conf"
+    install -Dm644 Makefile test.c v4l2loopback-dc.c "${srcdir}/dkms.conf" -t "${pkgdir}/usr/src/${_pkgname}-${pkgver}"
 }