Review Results

Comment

The change is low risk. It only alters version sorting from lexicographic to version-aware sorting when selecting the extracted WebStorm build directory, which improves correctness and does not introduce new sources, commands, privilege changes, or packaging side effects. No security-relevant behavior is added or removed.

@@ -23,7 +23,7 @@ package_webstorm() {
   optdepends=('webstorm-jre: JetBrains custom Java Runtime (Recommended)'
               'java-runtime: JRE - Required if webstorm-jre is not installed'
               'gnome-keyring: save login/deployment credentials safely')
-  _buildver="$(ls | grep -Eo 'WebStorm-[[:digit:]]+\.[[:digit:]]{2,5}\.[[:digit:]]+' | sort -r | head -1 | sed 's#WebStorm-##')"
+  _buildver="$(ls | grep -Eo 'WebStorm-[[:digit:]]+\.[[:digit:]]{2,5}\.[[:digit:]]+' | sort -rV | head -1 | sed 's#WebStorm-##')"
 
   install -dm755 "${pkgdir}"/opt/
   install -dm755 "${pkgdir}"/usr/bin/

Comment

The change is limited to version selection logic in PKGBUILD: `sort -r` was replaced with `sort -rV` when choosing the highest WebStorm build directory. This improves correctness for dotted version strings and does not introduce network access, privilege escalation, packaging outside `$pkgdir`, or other security-relevant behavior. No suspicious sources, scripts, or install-time actions are added by this diff.

@@ -42,7 +42,7 @@ package_webstorm() {
 package_webstorm-jre() {
   pkgdesc='JBR (JetBrains Runtime) for WebStorm - a patched JRE'
   url='https://github.com/JetBrains/JetBrainsRuntime'
-  _buildver="$(ls | grep -Eo 'WebStorm-[[:digit:]]+\.[[:digit:]]{2,5}\.[[:digit:]]+' | sort -r | head -1 | sed 's#WebStorm-##')"
+  _buildver="$(ls | grep -Eo 'WebStorm-[[:digit:]]+\.[[:digit:]]{2,5}\.[[:digit:]]+' | sort -rV | head -1 | sed 's#WebStorm-##')"
 
   install -dm755 "${pkgdir}"/opt/${pkgbase}
   cp -a WebStorm-${_buildver:?_buildver unset}/jbr "${pkgdir}"/opt/${pkgbase}