AUR AI Reviewer

Review Results

Version #3167 of retroshare · commit 3f8af82bc1a0 · status Reviewed

Risk 0/5 · Safe .SRCINFO
Result #6514

Comment

The only change in this .SRCINFO diff is a pkgrel bump from 1 to 2, with no changes to sources, checksums, dependencies, install scripts, or build logic. This is a metadata-only rebuild and does not introduce any new security-relevant behavior.

@@ -1,7 +1,7 @@
 pkgbase = retroshare
 	pkgdesc = Serverless encrypted instant messenger with filesharing, chatgroups, e-mail
 	pkgver = 0.6.7.3
-	pkgrel = 1
+	pkgrel = 2
 	url = https://github.com/retroshare/retroshare
 	arch = x86_64
 	license = AGPL-3.0-only
Risk 0/5 · Safe .SRCINFO
Result #6515

Comment

The .SRCINFO change is low risk. It only updates the pinned upstream git commit and adds a new runtime dependency on openssl-3. The source remains an HTTPS GitHub URL pinned to a specific commit, with no new build-time downloads, scripts, or packaging logic introduced in this diff. I don't see any indication of a supply-chain or persistence issue from this metadata-only change.

@@ -14,11 +14,12 @@ pkgbase = retroshare
 	depends = json-c
 	depends = libxss
 	depends = miniupnpc
+	depends = openssl-3
 	depends = qt6-5compat
 	depends = qt6-base
 	depends = qt6-multimedia
 	depends = sqlcipher
-	source = retroshare::git+https://github.com/retroshare/retroshare.git#commit=50b8967eccbee2642b4d37c20c9a36b2e13e6f4f
+	source = retroshare::git+https://github.com/retroshare/retroshare.git#commit=ceac16fd3f6ca0a565a738e022279b432a25be1b
 	sha256sums = SKIP
 
 pkgname = retroshare
Risk 0/5 · Safe PKGBUILD
Result #6516

Comment

The change is a straightforward version bump plus build/link adjustments for OpenSSL 3. It keeps the source pinned to a specific git commit over HTTPS, does not introduce new network fetches, scripts, or privilege-related behavior, and only adds include/library search paths for the system OpenSSL 3 package. The dependency update to openssl-3 and the soname comments are consistent with that intent. No obvious supply-chain or persistence red flags are introduced by this diff.

@@ -6,12 +6,12 @@
 # separate submodule paths with :
 : ${_broken_submodules=}
 
-: ${_commit:=50b8967eccbee2642b4d37c20c9a36b2e13e6f4f} # 0.6.7.3.r883
+: ${_commit:=ceac16fd3f6ca0a565a738e022279b432a25be1b} # 0.6.7.3.r1127
 
 _pkgname="retroshare"
 pkgname="$_pkgname"
 pkgver=0.6.7.3
-pkgrel=1
+pkgrel=2
 pkgdesc="Serverless encrypted instant messenger with filesharing, chatgroups, e-mail"
 url="https://github.com/retroshare/retroshare"
 license=('AGPL-3.0-only')
Risk 0/5 · Safe PKGBUILD
Result #6517

Comment

The change only adds an explicit dependency on openssl-3 and adjusts build flags to include its headers and library path. This does not introduce new code execution, network access, privilege escalation, or packaging behavior changes. The package already depended on OpenSSL symbols indirectly; making the dependency explicit and pointing the build at the system OpenSSL 3 include/lib directories is a normal compatibility fix. No suspicious sources, scripts, or install-time actions are added in this hunk.

@@ -22,6 +22,7 @@ depends=(
   'json-c'
   'libxss'
   'miniupnpc'
+  'openssl-3'
   'qt6-5compat'
   'qt6-base'
   'qt6-multimedia'
Risk 0/5 · Safe PKGBUILD
Result #6518

Comment

The change is a packaging-only rebuild to target OpenSSL 3: it adds the openssl-3 dependency and adjusts compiler/linker search paths to /usr/include/openssl-3 and /usr/lib/openssl-3. I do not see any new network fetches, privilege escalation, install-script changes, or suspicious post-install behavior. The added flags are unusual but consistent with selecting a specific system OpenSSL ABI and do not by themselves introduce a security issue in this diff.

@@ -66,7 +67,8 @@ prepare() {
 }
 
 build() {
-  export CXXFLAGS+=" -include cstring"
+  export CXXFLAGS+=" -include cstring -I/usr/include/openssl-3"
+  export LDFLAGS+=" -L/usr/lib/openssl-3"
 
   local _qmake_options=(
     CONFIG+=release
Risk 0/5 · Safe PKGBUILD
Result #6519

Comment

The change is a straightforward rebuild against OpenSSL 3: it updates the pinned upstream commit, adds the openssl-3 dependency, and adjusts include/library search paths plus soname comments. I do not see any new network fetches, privilege escalation, persistence mechanisms, or packaging outside $pkgdir. The use of eval here pre-existed and the dependency list remains limited to expected system libraries. No security-relevant red flags are introduced by this diff.

@@ -87,10 +89,10 @@ package() {
   if [[ "${_use_sodeps::1}" == "t" ]]; then
     eval "depends+=(
       'libbz2.so'    # bzip2
-      'libcrypto.so' # openssl
+      'libcrypto.so' # openssl-3
       'libjson-c.so' # json-c
       'libminiupnpc.so'
-      'libssl.so'    # openssl
+      'libssl.so'    # openssl-3
       'libz.so'      # zlib
     )"
   fi